Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the execution sweep sql to resolve the exec deletion conflict #20603

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

chlins
Copy link
Member

@chlins chlins commented Jun 17, 2024

Resolve the execution deletion conflict when there are tasks still referenced by the execution, remained execs can wait for next sweep cycle.

Comprehensive Summary of your change

Issue being fixed

Fixes

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

…flict

Resolve the execution deleteion conflict when there are tasks still
referenced by the execution, remained execs can wait for next sweep
cycle.

Signed-off-by: chlins <chlins.zhang@gmail.com>
@chlins chlins added the release-note/update Update or Fix label Jun 17, 2024
@chlins chlins requested a review from a team as a code owner June 17, 2024 06:54
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.24%. Comparing base (b7b8847) to head (9420cc7).
Report is 221 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20603      +/-   ##
==========================================
- Coverage   67.56%   66.24%   -1.32%     
==========================================
  Files         991     1045      +54     
  Lines      109181   113476    +4295     
  Branches     2719     2845     +126     
==========================================
+ Hits        73768    75177    +1409     
- Misses      31449    34191    +2742     
- Partials     3964     4108     +144     
Flag Coverage Δ
unittests 66.24% <0.00%> (-1.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/pkg/task/sweep_manager.go 36.22% <0.00%> (ø)

... and 571 files with indirect coverage changes

Copy link
Contributor

@stonezdj stonezdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit df4ab85 into goharbor:main Jun 17, 2024
10 of 12 checks passed
@Kajot-dev
Copy link

Is there any chance this gets cherry-picked to 2.11?

wy65701436 added a commit to wy65701436/harbor that referenced this pull request Aug 8, 2024
Signed-off-by: wang yan <wangyan@vmware.com>
chlins pushed a commit that referenced this pull request Aug 8, 2024
Signed-off-by: wang yan <wangyan@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants