remove migrate-patch #20619
Merged
remove migrate-patch #20619
+0
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR goharbor#18668 (commit bf7c82b) removed notary, but the source code of migrate-patch and some process in the Makefile for it remained, so remove them. Signed-off-by: Mitsuru Kariya <mitsuru.kariya@nttdata.com>
zyyw
approved these changes
Jul 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20619 +/- ##
===========================================
+ Coverage 45.36% 66.28% +20.91%
===========================================
Files 244 1045 +801
Lines 13333 114079 +100746
Branches 2719 2845 +126
===========================================
+ Hits 6049 75612 +69563
- Misses 6983 34348 +27365
- Partials 301 4119 +3818
Flags with carried forward coverage won't be shown. Click here to find out more. |
wy65701436
added a commit
to wy65701436/harbor
that referenced
this pull request
Aug 9, 2024
cherry pick goharbor#20619 Signed-off-by: wang yan <wangyan@vmware.com>
wy65701436
added a commit
to wy65701436/harbor
that referenced
this pull request
Aug 9, 2024
cherry pick goharbor#20619 Signed-off-by: wang yan <wangyan@vmware.com>
wy65701436
added a commit
to wy65701436/harbor
that referenced
this pull request
Aug 9, 2024
cherry pick goharbor#20619 Signed-off-by: wang yan <wangyan@vmware.com>
zyyw
pushed a commit
that referenced
this pull request
Aug 12, 2024
cherry pick #20619 Signed-off-by: wang yan <wangyan@vmware.com>
kunal-511
pushed a commit
to kunal-511/harbor_local
that referenced
this pull request
Aug 22, 2024
PR goharbor#18668 (commit bf7c82b) removed notary, but the source code of migrate-patch and some process in the Makefile for it remained, so remove them. Signed-off-by: Mitsuru Kariya <mitsuru.kariya@nttdata.com> Co-authored-by: Shengwen YU <yshengwen@vmware.com> Co-authored-by: Wang Yan <wangyan@vmware.com> Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comprehensive Summary of your change
PR #18668 (commit bf7c82b) removed notary, but the source code of
migrate-patchand some process in theMakefilefor it remained, so remove them.Issue being fixed
Please indicate you've done the following: