Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Swagger API docs #20841

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Fix typo in Swagger API docs #20841

merged 1 commit into from
Aug 13, 2024

Conversation

johankok
Copy link
Contributor

Comprehensive Summary of your change

Fix typo in the Swagger API docs.

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: Johan Kok <post@johankok.nl>
@johankok johankok requested a review from a team as a code owner August 12, 2024 16:07
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins added the release-note/ignore-for-release Do not include PR or Issue for release notes label Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.28%. Comparing base (c8c11b4) to head (9aee44f).
Report is 258 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20841       +/-   ##
===========================================
+ Coverage   45.36%   66.28%   +20.91%     
===========================================
  Files         244     1045      +801     
  Lines       13333   114079   +100746     
  Branches     2719     2845      +126     
===========================================
+ Hits         6049    75612    +69563     
- Misses       6983    34348    +27365     
- Partials      301     4119     +3818     
Flag Coverage Δ
unittests 66.28% <ø> (+20.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1286 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 907709f into goharbor:main Aug 13, 2024
13 of 14 checks passed
kunal-511 pushed a commit to kunal-511/harbor_local that referenced this pull request Aug 22, 2024
Signed-off-by: Johan Kok <post@johankok.nl>
Signed-off-by: kunal-511 <yoyokvunal@gmail.com>
@johankok johankok deleted the fix-typo-in-swagger-docs branch September 4, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants