Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update helm.sh/helm/v3 and github.com/google/go-containerregistry #20858

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Aug 19, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
@zyyw zyyw added the release-note/update Update or Fix label Aug 19, 2024
@zyyw zyyw requested a review from a team as a code owner August 19, 2024 08:20
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.27%. Comparing base (c8c11b4) to head (79e4edf).
Report is 263 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20858       +/-   ##
===========================================
+ Coverage   45.36%   66.27%   +20.90%     
===========================================
  Files         244     1046      +802     
  Lines       13333   114162   +100829     
  Branches     2719     2845      +126     
===========================================
+ Hits         6049    75661    +69612     
- Misses       6983    34376    +27393     
- Partials      301     4125     +3824     
Flag Coverage Δ
unittests 66.27% <ø> (+20.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1286 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw merged commit 15b3d53 into goharbor:main Aug 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants