Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in src/common #20861

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Fix typos in src/common #20861

merged 1 commit into from
Aug 28, 2024

Conversation

BruceAko
Copy link
Contributor

@BruceAko BruceAko commented Aug 20, 2024

Comprehensive Summary of your change

Fix typos in src/common.

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@BruceAko BruceAko requested a review from a team as a code owner August 20, 2024 04:48
@BruceAko BruceAko marked this pull request as draft August 21, 2024 06:29
@BruceAko BruceAko marked this pull request as ready for review August 21, 2024 06:29
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins added the release-note/ignore-for-release Do not include PR or Issue for release notes label Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 66.27%. Comparing base (c8c11b4) to head (7989901).
Report is 267 commits behind head on main.

Files Patch % Lines
src/common/api/base.go 0.00% 2 Missing ⚠️
src/common/http/tls.go 0.00% 1 Missing ⚠️
src/server/route.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20861       +/-   ##
===========================================
+ Coverage   45.36%   66.27%   +20.91%     
===========================================
  Files         244     1047      +803     
  Lines       13333   114254   +100921     
  Branches     2719     2847      +128     
===========================================
+ Hits         6049    75726    +69677     
- Misses       6983    34398    +27415     
- Partials      301     4130     +3829     
Flag Coverage Δ
unittests 66.27% <33.33%> (+20.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/common/job/client.go 39.77% <ø> (ø)
src/common/secret/request.go 100.00% <ø> (ø)
src/common/utils/email/mail.go 35.05% <ø> (ø)
src/common/utils/encrypt.go 64.15% <100.00%> (ø)
src/common/utils/passports.go 86.27% <ø> (ø)
src/common/utils/test/config.go 0.00% <ø> (ø)
src/common/utils/test/test.go 0.00% <ø> (ø)
src/common/utils/utils.go 81.81% <ø> (ø)
src/common/http/tls.go 61.76% <0.00%> (ø)
src/server/route.go 0.00% <0.00%> (ø)
... and 1 more

... and 1276 files with indirect coverage changes

Signed-off-by: BruceAko <chongzhi@hust.edu.cn>
@chlins chlins merged commit 234cd4f into goharbor:main Aug 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants