Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fr-fr-lang.json #20942

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Update fr-fr-lang.json #20942

merged 1 commit into from
Sep 20, 2024

Conversation

tostt
Copy link
Contributor

@tostt tostt commented Sep 18, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Signed-off-by: tostt <tostt@users.noreply.github.com>
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.73%. Comparing base (c8c11b4) to head (ba3f87c).
Report is 277 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20942       +/-   ##
===========================================
+ Coverage   45.36%   66.73%   +21.36%     
===========================================
  Files         244     1047      +803     
  Lines       13333   114271   +100938     
  Branches     2719     2847      +128     
===========================================
+ Hits         6049    76258    +70209     
- Misses       6983    34136    +27153     
- Partials      301     3877     +3576     
Flag Coverage Δ
unittests 66.73% <ø> (+21.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1287 files with indirect coverage changes

@wy65701436 wy65701436 added the help wanted The issues that is valid but needs help from community label Sep 19, 2024
@chlins chlins added the release-note/update Update or Fix label Sep 20, 2024
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 8d52a63 into goharbor:main Sep 20, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The issues that is valid but needs help from community release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants