Add Prettier format script for consistent code formatting in UI files #20998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vad1mo
added
the
release-note/infra
|
Can you add the run to the Github Action checks and fail the checks if there are errors
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20998 +/- ##
===========================================
+ Coverage 45.36% 68.81% +23.44%
===========================================
Files 244 802 +558
Lines 13333 100791 +87458
Branches 2719 0 -2719
===========================================
+ Hits 6049 69362 +63313
- Misses 6983 27623 +20640
- Partials 301 3806 +3505
Flags with carried forward coverage won't be shown. Click here to find out more. |
bupd
force-pushed
the
update-formatting
branch
3 times, most recently
from
fd4a4b9 to
00c3718
Compare
* Added npm script to format code using Prettier: `npm run format`. * Apply Prettier formatting across the project to ensure consistent code style. * Fix formatting inconsistencies in 123 files. * Improve overall code readability and maintainability. Signed-off-by: bupd <bupdprasanth@gmail.com>
* Updated 'ui_ut_run.sh' script to enforce formatting Signed-off-by: bupd <bupdprasanth@gmail.com>
bupd
force-pushed
the
update-formatting
branch
from
00c3718 to
51dc32f
Compare
|
ready for review |
Vad1mo
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR uses Prettier to the frontend component of the Harbor project to enforce consistent code formatting across frontend files. Currently, the frontend codebase has inconsistent formatting, which makes contributions more error-prone and increases unnecessary diffs in PRs.
By adding npm format script, we can ensure uniform formatting, which will improve the overall readability and maintainability of the code. It also reduces potential formatting-related issues in future PRs, ensuring that the focus stays on functionality rather than style.
npm run prettier).TO-DO
Issue being fixed
N/A (This is an enhancement to improve code quality and consistency).
Please indicate you've done the following: