Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the robot update permission #21028

Merged
merged 3 commits into from
Oct 12, 2024
Merged

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Oct 10, 2024

from the perspective of preventing privilege escalation, remove the robot update permission from the possilbe permission set

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

from the perspective of preventing privilege escalation, remove the robot update permission from the possilbe permission set

Signed-off-by: wang yan <wangyan@vmware.com>
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.10%. Comparing base (c8c11b4) to head (280ebcd).
Report is 294 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #21028       +/-   ##
===========================================
+ Coverage   45.36%   66.10%   +20.73%     
===========================================
  Files         244     1049      +805     
  Lines       13333   114602   +101269     
  Branches     2719     2856      +137     
===========================================
+ Hits         6049    75759    +69710     
- Misses       6983    34702    +27719     
- Partials      301     4141     +3840     
Flag Coverage Δ
unittests 66.10% <ø> (+20.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/common/rbac/const.go 10.63% <ø> (ø)
src/server/v2.0/handler/robot.go 12.71% <ø> (ø)

... and 1287 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 66ccf30 into goharbor:main Oct 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants