-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Overflow in Interrogation Services Page #21043
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21043 +/- ##
===========================================
+ Coverage 45.36% 66.10% +20.73%
===========================================
Files 244 1049 +805
Lines 13333 114645 +101312
Branches 2719 2867 +148
===========================================
+ Hits 6049 75790 +69741
- Misses 6983 34716 +27733
- Partials 301 4139 +3838
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you are already on it @bupd
having a fully vertical alignment (instead of a mix between both) is probably a better option.
7e586cb
to
1e2a9c8
Compare
@bupd can you add yet another screenshot |
Sure, @Vad1mo Screenshot |
Signed-off-by: bupd <bupdprasanth@gmail.com>
* adds padding in between scan now and results of the scan Signed-off-by: bupd <bupdprasanth@gmail.com>
1e2a9c8
to
6f4796a
Compare
Thank you for contributing to Harbor!
Comprehensive Summary of your change
fixes overflow in Interrogation Services -> Vulnerability Page.
The issue has been successfully resolved for screen resolutions of 1280x720 and higher.
Screenshots
Before
on screen 1280x720
After
on screen 1280x720
Issue being fixed
Fixes #20818
Please indicate you've done the following: