-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change setHealth to setUnHealth to avoid misunderstanding #21047
Conversation
fixes goharbor#19923 Signed-off-by: stonezdj <stone.zhang@broadcom.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21047 +/- ##
===========================================
+ Coverage 45.36% 66.10% +20.73%
===========================================
Files 244 1049 +805
Lines 13333 114645 +101312
Branches 2719 2867 +148
===========================================
+ Hits 6049 75788 +69739
- Misses 6983 34718 +27735
- Partials 301 4139 +3838
Flags with carried forward coverage won't be shown. Click here to find out more. |
82ce378
to
41f235e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
51c080d
to
82ce378
Compare
fixes #19923
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: