Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporary disable gpg sign #21085

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Oct 24, 2024

to avoid blocking the rc, let's temporary disable the gpg sign for development build since the key was expired at Oct 21. I will fix it after RC and revert the code change

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

to avoid blocking the rc, let's temporary disable the gpg sign for development build since the key was expired at Oct 21.
I will fix it after RC and revert the code change

Signed-off-by: wang yan <wangyan@vmware.com>
Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.08%. Comparing base (c8c11b4) to head (a0a1189).
Report is 303 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #21085       +/-   ##
===========================================
+ Coverage   45.36%   66.08%   +20.72%     
===========================================
  Files         244     1049      +805     
  Lines       13333   114649   +101316     
  Branches     2719     2867      +148     
===========================================
+ Hits         6049    75770    +69721     
- Misses       6983    34735    +27752     
- Partials      301     4144     +3843     
Flag Coverage Δ
unittests 66.08% <ø> (+20.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1288 files with indirect coverage changes

@wy65701436 wy65701436 merged commit bfa67a7 into goharbor:main Oct 24, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants