Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding supported Node Version for Harbor #21153

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

bupd
Copy link
Member

@bupd bupd commented Nov 8, 2024

Summary

  • Updates README to clarify the steps to setup Harbor UI.
  • Specifies correct Node.js version to run Harbor UI.

Changes made

  • added .nvmrc (to indicate node version)
  • updated docs to be clear for newcomers.

Issue being fixed

Fixes #21044

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@bupd bupd requested a review from a team as a code owner November 8, 2024 08:55
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.25%. Comparing base (c8c11b4) to head (dbc1e01).
Report is 338 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21153      +/-   ##
==========================================
+ Coverage   45.36%   46.25%   +0.88%     
==========================================
  Files         244      247       +3     
  Lines       13333    13863     +530     
  Branches     2719     2867     +148     
==========================================
+ Hits         6049     6412     +363     
- Misses       6983     7113     +130     
- Partials      301      338      +37     
Flag Coverage Δ
unittests 46.25% <ø> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

@bupd bupd force-pushed the fix-ui-err branch 3 times, most recently from 55f922c to 61646a6 Compare November 8, 2024 14:38
@MinerYang
Copy link
Contributor

Please refer to #21044 (comment)

Signed-off-by: bupd <bupdprasanth@gmail.com>

update nvmrc to supported version

Signed-off-by: bupd <bupdprasanth@gmail.com>
@bupd
Copy link
Member Author

bupd commented Nov 15, 2024

@MinerYang update .nvmrc to the supported version.

@Vad1mo Vad1mo changed the title Fix Issue #21044 Adding supported Node Version for Harbor Dec 9, 2024
@Vad1mo Vad1mo added the release-note/infra Infra related changes e.g. release, test, ship etc... label Dec 9, 2024
@bupd bupd added the area/ui label Dec 16, 2024
@bupd
Copy link
Member Author

bupd commented Dec 16, 2024

Ready for review and merge.!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harbor UI Development: npm start Fails to Compile
6 participants