-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding supported Node Version for Harbor #21153
Open
bupd
wants to merge
3
commits into
goharbor:main
Choose a base branch
from
bupd:fix-ui-err
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21153 +/- ##
==========================================
+ Coverage 45.36% 46.25% +0.88%
==========================================
Files 244 247 +3
Lines 13333 13863 +530
Branches 2719 2867 +148
==========================================
+ Hits 6049 6412 +363
- Misses 6983 7113 +130
- Partials 301 338 +37
Flags with carried forward coverage won't be shown. Click here to find out more. |
bupd
force-pushed
the
fix-ui-err
branch
3 times, most recently
from
November 8, 2024 14:38
55f922c
to
61646a6
Compare
Please refer to #21044 (comment) |
Signed-off-by: bupd <bupdprasanth@gmail.com> update nvmrc to supported version Signed-off-by: bupd <bupdprasanth@gmail.com>
@MinerYang update .nvmrc to the supported version. |
Vad1mo
added
the
release-note/infra
Infra related changes e.g. release, test, ship etc...
label
Dec 9, 2024
Ready for review and merge.!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
README
to clarify the steps to setup Harbor UI.Changes made
.nvmrc
(to indicate node version)Issue being fixed
Fixes #21044
Please indicate you've done the following: