Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: Update "Copy Pull Command" Button Location #21155

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

bupd
Copy link
Contributor

@bupd bupd commented Nov 8, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

  • Move copy pull command button inside the table
  • Add separate table for the button.

Issue being fixed

Fixes #21146

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.31%. Comparing base (c8c11b4) to head (d1c4a46).
Report is 333 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21155      +/-   ##
==========================================
+ Coverage   45.36%   46.31%   +0.94%     
==========================================
  Files         244      248       +4     
  Lines       13333    13922     +589     
  Branches     2719     2869     +150     
==========================================
+ Hits         6049     6448     +399     
- Misses       6983     7133     +150     
- Partials      301      341      +40     
Flag Coverage Δ
unittests 46.31% <ø> (+0.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 492 files with indirect coverage changes

---- 🚨 Try these New Features:

@bupd
Copy link
Contributor Author

bupd commented Nov 8, 2024

Screenshot

ss pr fix

@Vad1mo Vad1mo added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label Nov 19, 2024
* This commit moves "Copy Pull Command" button inside the table
* and add a separate column for better usability

Signed-off-by: bupd <bupdprasanth@gmail.com>
* This Commit adds Preferences in navbar
* Updates the navbar

Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request Proposal: Improve "Copy Pull Command" Functionality for Enhanced User Experience
2 participants