Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testcase for test env change, especially for webhook config #21191

Merged

Conversation

stonezdj
Copy link
Contributor

Change dockhub to registry.goharbor.io
Change the testcase for webhook

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

…tion

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
@stonezdj stonezdj requested a review from a team as a code owner November 15, 2024 06:01
@stonezdj stonezdj added the release-note/ignore-for-release Do not include PR or Issue for release notes label Nov 15, 2024
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 529375f into goharbor:release-2.11.0 Nov 22, 2024
18 of 19 checks passed
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-2.11.0@201d421). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.11.0   #21191   +/-   ##
=================================================
  Coverage                  ?   66.30%           
=================================================
  Files                     ?     1044           
  Lines                     ?   113939           
  Branches                  ?     2845           
=================================================
  Hits                      ?    75549           
  Misses                    ?    34266           
  Partials                  ?     4124           
Flag Coverage Δ
unittests 66.30% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants