Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: add support for configuring new Trivy environment variables via harbor.yml #21193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

quent1-fr
Copy link

This update allows Harbor administrators to configure two new Trivy environment variables directly through the harbor.yml configuration file:

  • SCANNER_TRIVY_DB_REPOSITORY: Specifies the repository URL for the Trivy vulnerability database.
  • SCANNER_TRIVY_JAVA_DB_REPOSITORY: Specifies the repository URL for the Trivy Java vulnerability database.

This enhancement simplifies Trivy configuration when using mirrors of vulnerability repositories.

@quent1-fr quent1-fr requested a review from a team as a code owner November 15, 2024 14:05
Signed-off-by: Quentin Bouteiller <quentin.bouteiller@values-associates.com>
@MinerYang
Copy link
Contributor

Hi @quent1-fr ,

Thanks for your contribution and please help to rebase the RP. thx~

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.09%. Comparing base (c8c11b4) to head (0af2129).
Report is 332 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #21193       +/-   ##
===========================================
+ Coverage   45.36%   66.09%   +20.72%     
===========================================
  Files         244     1049      +805     
  Lines       13333   114654   +101321     
  Branches     2719     2867      +148     
===========================================
+ Hits         6049    75783    +69734     
- Misses       6983    34732    +27749     
- Partials      301     4139     +3838     
Flag Coverage Δ
unittests 66.09% <ø> (+20.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1288 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants