Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] fix robot deletion event (#21234) #21272

Merged

Conversation

wy65701436
Copy link
Contributor

  • fix robot deletion event

  • resolve comments


Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

* fix robot deletion event

Signed-off-by: wang yan <wangyan@vmware.com>

* resolve comments

Signed-off-by: wang yan <wangyan@vmware.com>

---------

Signed-off-by: wang yan <wangyan@vmware.com>
@wy65701436 wy65701436 requested a review from a team as a code owner December 3, 2024 05:53
@wy65701436 wy65701436 changed the title fix robot deletion event (#21234) [cherry-pick] fix robot deletion event (#21234) Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-2.12.0@7201b3b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/controller/event/metadata/robot.go 14.28% 3 Missing and 3 partials ⚠️
src/controller/robot/controller.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.12.0   #21272   +/-   ##
=================================================
  Coverage                  ?   66.07%           
=================================================
  Files                     ?     1049           
  Lines                     ?   114656           
  Branches                  ?     2867           
=================================================
  Hits                      ?    75764           
  Misses                    ?    34745           
  Partials                  ?     4147           
Flag Coverage Δ
unittests 66.07% <40.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/controller/robot/model.go 100.00% <ø> (ø)
src/controller/scan/callback.go 60.86% <100.00%> (ø)
src/controller/robot/controller.go 55.74% <57.14%> (ø)
src/controller/event/metadata/robot.go 70.96% <14.28%> (ø)

Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit b72b5ce into goharbor:release-2.12.0 Dec 3, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants