Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert change of artifact event #21278

Merged

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Dec 4, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@wy65701436 wy65701436 requested a review from a team as a code owner December 4, 2024 04:54
@wy65701436 wy65701436 assigned reasonerjt and unassigned Vad1mo, zyyw and MinerYang Dec 4, 2024
fixes goharbor#20897
Signed-off-by: wang yan <wangyan@vmware.com>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 force-pushed the release-2.12.0-art-event branch from 5a8bf20 to 7706996 Compare December 4, 2024 04:57
@wy65701436 wy65701436 added the release-note/update Update or Fix label Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-2.12.0@7201b3b). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.12.0   #21278   +/-   ##
=================================================
  Coverage                  ?   68.79%           
=================================================
  Files                     ?      802           
  Lines                     ?   100791           
  Branches                  ?        0           
=================================================
  Hits                      ?    69340           
  Misses                    ?    27640           
  Partials                  ?     3811           
Flag Coverage Δ
unittests 68.79% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/controller/artifact/controller.go 62.15% <100.00%> (ø)

@wy65701436 wy65701436 merged commit cdb0d2f into goharbor:release-2.12.0 Dec 4, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants