-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replication rule message in UI #21299
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21299 +/- ##
==========================================
+ Coverage 45.36% 46.27% +0.90%
==========================================
Files 244 247 +3
Lines 13333 13863 +530
Branches 2719 2867 +148
==========================================
+ Hits 6049 6415 +366
- Misses 6983 7109 +126
- Partials 301 339 +38
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some original language description has been translated into English, but it does not make sense.
thanks for pointing out @chlins . The chinese version is already clear so will update only the other languages which is not clear. |
* updates replication rule confirm message for execution in UI * update en-us-lang and es-es-lang with clear focus on execution * Since different languages have varying interpretations of 'execution' * Its better to update only the English version Signed-off-by: bupd <bupdprasanth@gmail.com>
Summary
Make Replication Confrimation Message Clear. By shifting focus on replication rule execution.
Title
Message
Changes Made
Before
After
Issue being fixed
Fixes #21292
Please indicate you've done the following: