Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix robot account creation issue #21310

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Dec 12, 2024

fixes #21251

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.19%. Comparing base (c8c11b4) to head (874c5ba).
Report is 337 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #21310      +/-   ##
==========================================
+ Coverage   45.36%   46.19%   +0.82%     
==========================================
  Files         244      247       +3     
  Lines       13333    13863     +530     
  Branches     2719     2867     +148     
==========================================
+ Hits         6049     6404     +355     
- Misses       6983     7123     +140     
- Partials      301      336      +35     
Flag Coverage Δ
unittests 46.19% <ø> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

fixes goharbor#21251

Signed-off-by: wang yan <wangyan@vmware.com>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@antoine-sncf
Copy link

End user testing in progress. we'll give you a feedback as fast as possible (i hope today)

@stonezdj stonezdj merged commit c7cf57b into goharbor:main Dec 13, 2024
12 of 13 checks passed
@antoine-sncf
Copy link

End user testing validated Friday. Thank you for your work on this topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Robot Accounts to Manage Robots with Full Permissions
6 participants