Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

writeStats = true is slow when combined with lots of pre element (e.g. Chroma highlighting) #10698

Closed
bep opened this issue Feb 5, 2023 · 2 comments · Fixed by #10700 or #10703
Closed

writeStats = true is slow when combined with lots of pre element (e.g. Chroma highlighting) #10698

bep opened this issue Feb 5, 2023 · 2 comments · Fixed by #10700 or #10703
Assignees
@bep
Labels
Bug Outdated
Milestone
v0.111.0

Comments

@bep
Copy link
Member

bep commented Feb 5, 2023

No description provided.

@bep bep self-assigned this Feb 5, 2023
@bep bep removed the NeedsTriage label Feb 5, 2023
@bep bep added this to the v0.111.0 milestone Feb 5, 2023
@bep bep mentioned this issue Feb 5, 2023
Merged
bep added a commit to bep/hugo that referenced this issue Feb 5, 2023
@bep
Fix slow HTML elements collector for the pre case
00a20f6 
```
name                           old time/op    new time/op    delta
ElementsCollectorWriterPre-10    25.2µs ± 1%     3.4µs ± 0%  -86.54%  (p=0.029 n=4+4)

name                           old alloc/op   new alloc/op   delta
ElementsCollectorWriterPre-10      624B ± 0%      142B ± 0%  -77.18%  (p=0.029 n=4+4)

name                           old allocs/op  new allocs/op  delta
ElementsCollectorWriterPre-10      16.0 ± 0%       6.0 ± 0%  -62.50%  (p=0.029 n=4+4)
```

Fixes gohugoio#10698
@bep bep closed this as completed in #10700 Feb 5, 2023
bep added a commit that referenced this issue Feb 5, 2023
@bep
Fix slow HTML elements collector for the pre case
f9fc0e0 
```
name                           old time/op    new time/op    delta
ElementsCollectorWriterPre-10    25.2µs ± 1%     3.4µs ± 0%  -86.54%  (p=0.029 n=4+4)

name                           old alloc/op   new alloc/op   delta
ElementsCollectorWriterPre-10      624B ± 0%      142B ± 0%  -77.18%  (p=0.029 n=4+4)

name                           old allocs/op  new allocs/op  delta
ElementsCollectorWriterPre-10      16.0 ± 0%       6.0 ± 0%  -62.50%  (p=0.029 n=4+4)
```

Fixes #10698
@bep
Copy link
Member Author

bep commented Feb 6, 2023

Reopen this, I have to make this more robust.

@bep bep reopened this Feb 6, 2023
@bep bep mentioned this issue Feb 6, 2023
Merged
bep added a commit to bep/hugo that referenced this issue Feb 6, 2023
@bep
Make the HTML collector parsing more robust
a810ced 
Most notably better handling self-closing elements

Closes gohugoio#10698
@bep bep closed this as completed in #10703 Feb 7, 2023
bep added a commit that referenced this issue Feb 7, 2023
@bep
Make the HTML collector parsing more robust
d33a7eb 
Most notably better handling self-closing elements

Closes #10698
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
v0.111.0
1 participant
@bep