Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a reserved template namespace #13278

Closed
jmooring opened this issue Jan 18, 2025 · 2 comments
Closed

Introduce a reserved template namespace #13278

jmooring opened this issue Jan 18, 2025 · 2 comments
Labels
Outdated Proposal
Milestone
v0.142.0

Comments

@jmooring
Copy link
Member

This would allow us to provide embedded templates than cannot be overridden. See #13277.
@jmooring jmooring mentioned this issue Jan 18, 2025
Closed
@bep bep removed the NeedsTriage label Jan 18, 2025
@bep bep added this to the v0.142.0 milestone Jan 18, 2025
@jmooring
Copy link
Member Author

Just to make sure we remember how we got here... we created the comments shortcode because with v0.137.0 and later we emit the "Raw HTML omitted while rendering" warning if the Markdown contains an HTML comment. If there were a way to not warn about HTML comments, this issue would be a very low priority.

bep added a commit to bep/hugo that referenced this issue Jan 21, 2025
@bep
Do not warn on potentially unsafe HTML comments when unsafe=false
e2bd987 
We will still not render these comments, so from a safety perspective this is the same, but HTML comments are very common also inside Markdown and too useful to throw away.

Updates gohugoio#13278
@bep bep mentioned this issue Jan 21, 2025
Merged
@gohugoio gohugoio deleted a comment from bep Jan 21, 2025
bep added a commit that referenced this issue Jan 22, 2025
@bep
Do not warn on potentially unsafe HTML comments when unsafe=false
f1de5d2 
We will still not render these comments, so from a safety perspective this is the same, but HTML comments are very common also inside Markdown and too useful to throw away.

Updates #13278
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Outdated Proposal
Projects
None yet
Milestone
v0.142.0
Development

No branches or pull requests
2 participants
@jmooring @bep