Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: Don't do full rebuilds on mass CHMOD events #13373

Closed
bep opened this issue Feb 10, 2025 · 1 comment · Fixed by #13374
Closed

server: Don't do full rebuilds on mass CHMOD events #13373

bep opened this issue Feb 10, 2025 · 1 comment · Fixed by #13374
Assignees
@bep
Labels
Bug Outdated
Milestone
v0.144.0

Comments

@bep
Copy link
Member

bep commented Feb 10, 2025

So, this comes from what seems to be a recently introduced bug (or feature) in my VSCode setup, but I think it makes sense to improve how we handle this in Hugo.

  • For file system changes, we normally do fine grained rebuilds, but skip CHMOD events.
  • But if number of events > 50 we assume a mass edit (e.g. change of Git branch), so we fall back to a full rebuild. We include CHMOD events in the count.

The fix to the above would be to filter out any CHMOD events before deciding what to do.
@bep bep added the Bug label Feb 10, 2025
@bep bep added this to the v0.144.0 milestone Feb 10, 2025
@bep bep self-assigned this Feb 10, 2025
bep added a commit to bep/hugo that referenced this issue Feb 10, 2025
@bep
commands: Move the CHMOD event filter up
be71f8e 
To prevent ghost rebuilds (from VSCode and possibly others).

Fixes gohugoio#13373
@bep bep mentioned this issue Feb 10, 2025
Merged
@bep bep closed this as completed in e6feb9e Feb 10, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Bug Outdated
Projects
None yet
Milestone
v0.144.0
Development

Successfully merging a pull request may close this issue.

commands: Move the CHMOD event filter up bep/hugo
1 participant
@bep