Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Template Blocks in Go 1.6 #1832

Closed
bep opened this issue Feb 9, 2016 · 4 comments
Closed

Add support for Template Blocks in Go 1.6 #1832

bep opened this issue Feb 9, 2016 · 4 comments
Assignees
@bep
Labels
Enhancement Outdated
Milestone
v0.16

Comments

@bep
Copy link
Member

bep commented Feb 9, 2016

Probably something similar to the baseof.ace templates.

golang/go#3812
@bep bep self-assigned this Feb 9, 2016
@bep bep added this to the v0.16 milestone Feb 9, 2016
@bep bep removed this from the v0.16 milestone Feb 10, 2016
@bep bep removed their assignment Feb 10, 2016
@bep
Copy link
Member Author

bep commented Feb 10, 2016

I cannot get this to work with Hugo. I don't understand it, and have wasted enough time. I'm happy enough with the Ace templates, but might take a stab at this at a later point in time

@bep bep self-assigned this Feb 10, 2016
This was referenced Feb 10, 2016
Closed
Closed
@bep bep added this to the v0.16 milestone Feb 12, 2016
@bep
Copy link
Member Author

bep commented Feb 12, 2016

OK, found a way to make this work without too intrusive changes. I still believe the Go team should have made a better job with this. To quote Rob PIke: "Simplicity is Complicated".

bep added a commit to bep/hugo that referenced this issue Mar 9, 2016
@bep
Add support for Go 1.6 block keyword in templates
7e7a888 
NOTE: Needs Go 1.6 to use the new feature.

Fixes gohugoio#1832
@bep bep closed this as completed in a2abad9 Mar 10, 2016
@anthonyfok
Copy link
Member

@bep, Kudos to you! You are awesome as always! Thank you for implementing this feature!

tychoish pushed a commit to tychoish/hugo that referenced this issue Aug 13, 2017
@bep @tychoish
Add support for Go 1.6 block keyword in templates
d6c9c13 
NOTE: Needs Go 1.6 to use the new feature.

Fixes gohugoio#1832
@github-actions
Copy link

github-actions bot commented Apr 8, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bep bep

Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.16
Development

Successfully merging a pull request may close this issue.

Add support for Go 1.6 block keyword in templates bep/hugo
2 participants
@bep @anthonyfok