Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate tmp file regression #2168

Closed
bep opened this issue May 26, 2016 · 6 comments
Closed

Investigate tmp file regression #2168

bep opened this issue May 26, 2016 · 6 comments
Assignees
@spf13
Labels
Bug Outdated
Milestone
v0.16

Comments

@bep
Copy link
Member

bep commented May 26, 2016

See b503078

Also see last comment in #2021

I added the Byword temp files exclude, but I have used Byword for a long time, so this is something that has happened in Hugo 0.16.
@bep bep added this to the v0.16 milestone May 26, 2016
@bep bep added the Bug label May 26, 2016
@bep
Copy link
Member Author

bep commented May 27, 2016

I have checked: I started using Byword last summer (to replace TextMate which had a livereload issue on OS X that is now fixed); we relased 0.15 in November, so I'm pretty sure this is a regression.

@bep
Copy link
Member Author

bep commented May 27, 2016 •
edited
Loading

I could maybe narrow it further, but this commit is working (as in: it does not get confused by temp files in atomic saves): ed3015c

@bep
Copy link
Member Author

bep commented May 27, 2016

This commit fails: c438f45

So it looks like one of your commits on Jan 26, 2016.

@spf13
Copy link
Contributor

spf13 commented Jun 2, 2016

@bep I'm glad you discovered this as it uncovered a major bug in Hugo. I've been able to identify and reproduce the issue. The issue extends far beyond Byword.

The problem is in the way Hugo now handles events. If a create and then rename event of the same file are triggered in the same notification event Hugo will hang trying to read the created file that is no longer present. The quick fix would be to enumerate and ignore all of the different temp files used but that’s not addressing the real issue. I'm working on a fix for it right now.

@spf13 spf13 closed this as completed Jun 2, 2016
@spf13 spf13 reopened this Jun 2, 2016
@bep
Copy link
Member Author

bep commented Jun 2, 2016

The quick fix would be to enumerate and ignore all of the different temp files used but that’s not addressing the real issue.

That seems like an impossible task -- there are plenty of editors out there ...

spf13 added a commit that referenced this issue Jun 2, 2016
@spf13
Handle errors during rereading properly
afce05b 
Without this fix, any error during rereading would cause Hugo to hang.
Fixes #2168
@spf13 spf13 mentioned this issue Jun 2, 2016
Closed
@bep bep closed this as completed in f94cd28 Jun 2, 2016
tychoish pushed a commit to tychoish/hugo that referenced this issue Aug 13, 2017
@spf13 @tychoish
Handle errors during rereading properly
2014550 
Without this fix, any error during rereading would cause Hugo to hang.
Fixes gohugoio#2168
Closes gohugoio#2179
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@spf13 spf13

Labels
Bug Outdated
Projects
None yet
Milestone
v0.16
Development

No branches or pull requests
2 participants
@spf13 @bep