Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

figure shortcode does not parse the height argument #4014

Closed
kaushalmodi opened this issue Oct 26, 2017 · 2 comments · Fixed by #4018
Closed

figure shortcode does not parse the height argument #4014

kaushalmodi opened this issue Oct 26, 2017 · 2 comments · Fixed by #4018
Labels
Outdated

Comments

@kaushalmodi
Copy link
Contributor

kaushalmodi commented Oct 26, 2017 •
edited
Loading

Looking at the source, only the width argument is parsed in the figure shortcode, not the height.

Discourse thread
@kaushalmodi
Copy link
Contributor Author

I can work on a PR. Though, I was wondering why the source (like the one I linked above) is stringent with newlines? With so many with .. ends on the same line, reading that code is difficult atleast in my opinion.

Would it be OK to break that figure code into multiple newlines in my PR?

kaushalmodi added a commit to kaushalmodi/hugo that referenced this issue Oct 27, 2017
@kaushalmodi
Add support for height argument to figure shortcode
b2e9ce5 
Fixes gohugoio#4014
@kaushalmodi kaushalmodi mentioned this issue Oct 27, 2017
Merged
kaushalmodi added a commit to kaushalmodi/hugo that referenced this issue Oct 29, 2017
@kaushalmodi
Add support for height argument to figure shortcode
249b413 
Fixes gohugoio#4014
@bep bep closed this as completed in #4018 Oct 29, 2017
bep pushed a commit that referenced this issue Oct 29, 2017
@kaushalmodi @bep
Add support for height argument to figure shortcode
488631f 
Fixes #4014
@dependencies dependencies bot mentioned this issue Nov 20, 2017
Merged
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for height argument to figure shortcode kaushalmodi/hugo
1 participant
@kaushalmodi