Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hugo 0.64 missing files in mounts #6854

Closed
XhmikosR opened this issue Feb 5, 2020 · 8 comments
Closed

Hugo 0.64 missing files in mounts #6854

XhmikosR opened this issue Feb 5, 2020 · 8 comments
Labels
Milestone

Comments

@XhmikosR
Copy link
Contributor

XhmikosR commented Feb 5, 2020

What version of Hugo are you using (hugo version)?

$ hugo version
Hugo Static Site Generator v0.64.0-241DB8F7 windows/amd64 BuildDate: 2020-02-04T09:09:27Z

Does this issue reproduce with the latest release?

Yes.

This does not happen with v0.63.2.

@bep
Copy link
Member

bep commented Feb 5, 2020

The latest Boostrap 4 SASS source fails to build with Hugo. We can do a bug trade ...

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Feb 5, 2020

I think this has already been fixed in master. Is there any issue about this?

@bep bep added this to the v0.64.1 milestone Feb 9, 2020
bep added a commit to bep/hugo that referenced this issue Feb 9, 2020

Verified

This commit was signed with the committer’s verified signature.
bep Bjørn Erik Pedersen
bep added a commit to bep/hugo that referenced this issue Feb 9, 2020

Verified

This commit was signed with the committer’s verified signature.
bep Bjørn Erik Pedersen
bep added a commit to bep/hugo that referenced this issue Feb 9, 2020

Verified

This commit was signed with the committer’s verified signature.
bep Bjørn Erik Pedersen
bep added a commit to bep/hugo that referenced this issue Feb 9, 2020

Verified

This commit was signed with the committer’s verified signature.
bep Bjørn Erik Pedersen
@bep bep closed this as completed in b78576f Feb 9, 2020
@bep
Copy link
Member

bep commented Feb 9, 2020

@XhmikosR no issue, and yes it's fixed in master.

Also, this issue should be fixed now. Sorry for the breakage; I had to dive into my own code to fix a related issue for 0.64, and I had a hard time understanding my own code, so I more or less rewrote the mount file system. That would have been splendid if we had solid test cases for your situation.

I took the Bootstrap site for a spin. Notice you build the SCSS source with Hugo -- pretty nice editing experience, I suspect.

@XhmikosR
Copy link
Contributor Author

We actually build only the docs SCSS with Hugo. In master there's no need to install anything else to fiddle with the docs :)

@XhmikosR
Copy link
Contributor Author

And thanks for the quick fix!

@bep
Copy link
Member

bep commented Feb 10, 2020

A little heads up about my latest addition to master: 40ba7e6 -- which updates LibSass to the newest release version. I tested it with the Bootstrap site and it "looked fine". node-sass is still on some old version (3.5.5?). Nothing particularly new functionality in this LibSass, but they're in the process of porting all the upstream Dart changes for LibSass 4.0 (Sass Modules ...?).

@XhmikosR
Copy link
Contributor Author

Yup. We test from time to time with Dart Sass for the core, and I plan to at least build everything on each commit with Dart Sass so that we at least catch compilation errors.

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants