-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
why template google_analytics_async not support google v4? #8549
Comments
GA4 support is now available (though via It seems that this issue can be closed. |
Addressed by #8287 |
@jmooring why does that patch address this issue? IIUC author is asking for Google Analytics 4 support in |
@kirillbobyrev I've reopened this issue. I do not use GA, and would appreciate clarification. Our documentation states:
And it looks the regular template loads the gtag script aysnchronously. So I assumed, perhaps incorrectly, that the async template was no longer relevant. |
@jmooring oh, actually, I think you are right, sorry, I think I didn't read the code carefully enough. The problem for me was that PageSpeed for mobile shows that the Google Analytics loading takes a long time and affects performance, so I thought that is because it isn't loaded asynchronously. But, looking closer, it isn't, so I was wrong, apologies for incorrect comment. I think, before looking at the code closely enough, I was very confused by the documentation and the template naming, i.e. I had an impression that I think you can close this issue, thanks for pointing me to the right code! |
@kirillbobyrev No problem. Thanks for the clarification. I think the documentation could use a little love: And I think we need to deprecate the async template: |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
my using theme is use google_analytics_async template. i want add google analytics to my blog, but it not work.
https://github.com/gohugoio/hugo/blob/3d5dbdcb1a11b059fc2f93ed6fadb9009bf72673/tpl/tplimpl/embedded/templates/google_analytics_async.html
i find the result is the google_analytics_async not support v4 code..
#8287
The text was updated successfully, but these errors were encountered: