dartsass: Import CSS without extension at compile time #10593
Conversation
Applicable to Dart Sass only: - Sass imports with the .css extension indicate a plain CSS @import. - Sass imports without the .css extension are imported at compile time. Fixes gohugoio#10592
|
|
||
| /* foo */ | ||
| -- assets/scss/regular.css -- | ||
|
|
||
| -- config.toml -- | ||
| -- layouts/index.html -- | ||
| {{ $r := resources.Get "scss/main.scss" | toCSS (dict "transpiler" "dartsass") }} | ||
| {{ $cssOpts := (dict "includePaths" (slice "node_modules/foo") "transpiler" "dartsass") }} |
There was a problem hiding this comment.
The original issue, as I understand it, was about importing CSS files from /assets; with that I don't understand why you move the CSS to node_modules?
There was a problem hiding this comment.
The original issue, as I understand it, was about importing CSS files from /assets
The OP incorrectly commented on what was working vs. what was not. I discovered their error when I began testing this, but did not ask the OP to verify their comments until yesterday. They confirmed that the original comments were reversed, but the issue title is correct.
We have no problem importing a CSS file in the assets directory at compile time. But when you import a CSS file from a mounted directory (either through module.mounts or the includePaths slice), the result is a plain import.
I would be happy to clarify the test if necessary, but I was trying to minimize the diff for you.
There was a problem hiding this comment.
I would be happy to clarify the test if necessary, but I was trying to minimize the diff for you.
To minimise the diff would be dropping the includePaths change, which is what confuses me -- even after rereading the original issue. I think I understand the issue, and if I understand it correctly that should be possible to reproduce by just importing a CSS file without using the extension when the file is imported into /assets in a mount (which lives outside of what includePaths is all about).
|
bep, I apologize for the delay on this. I have been having intermittent failures when testing. It turns out the tests were intermittently skipped due to: if !dartsass.Supports() {
t.Skip()
}That is not your problem. I had been running the tests (a) within VS Code, and (b) with dart-sass-embedded installed via Brew. There are no problems when dart-sass-embedded is installed in /user/local/bin. I still haven't worked out the correct settings in VS Code to address this, so I'll stick with the install in /user/local/bin. |
|
Bump ... Is this still an issue/relevant? |
|
Yes, still relevant, got distracted. I can look at it again later today (much later today). |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Applicable to Dart Sass only:
Fixes #10592