Fix case issues with Params #2630
Conversation
bep
force-pushed
the
fix-caseins
branch
24 times, most recently
from
b5d4d5e to
48269a1
Compare
|
/cc @moonytheloony @spf13 @tatsushid and friends. |
bep
force-pushed
the
fix-caseins
branch
2 times, most recently
from
1ef5828 to
3eda2e7
Compare
|
Will this commit enforce that we can't have 2 variables with the same name but different casing? e.g. someVariable, somevariable and SomeVariable would ultimately mean the same thing? |
The commit will not change anything in that department: The Params keys are case insensitive, i.e. Foo is the same as foo. This is how it is already, but if you ask for Foo, you don't get it. After this commit, you do. |
|
@spf13 you out there? |
|
No comments on this PR? |
|
Interesting approach. I don't see anything wrong with it and can confirm that it fixes Params issues I've seen since 0.17. LGTM 👍 PS - I was daydreaming the other day about having a |
There are currently several Params and case related issues floating around in Hugo. This is very confusing for users and one of the most common support questions on the forum. And while there have been done some great leg work in Viper etc., this is of limited value since this and similar doesn't work: `Params.myCamelCasedParam` Hugo has control over all the template method invocations, and can take care of all the lower-casing of the map lookup keys. But that doesn't help with direct template lookups of type `Site.Params.TWITTER_CONFIG.USER_ID`. This commit solves that by doing some carefully crafted modifications of the templates' AST -- lowercasing the params keys. This is low-level work, but it's not like the template API wil change -- and this is important enough to defend such "bit fiddling". Tests are added for all the template engines: Go templates, Ace and Amber. Fixes gohugoio#2615 Fixes gohugoio#1129 Fixes gohugoio#2590
|
@mdhender this is a PR. If you have an issue with params, please create a new issue for it. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
There are currently several Params and case related issues floating around in Hugo.
This is very confusing for users and one of the most common support questions on the forum.
And while there have been done some great leg work in Viper etc., this is of limited value since this and similar doesn't work:
Params.myCamelCasedParamHugo has control over all the template method invocations, and can take care of all the lower-casing of the map lookup keys.
But that doesn't help with direct template lookups of type
Site.Params.TWITTER_CONFIG.USER_ID.This commit solves that by doing some carefully crafted modifications of the templates' AST -- lowercasing the params keys.
This is low-level work, but it's not like the template API wil change -- and this is important enough to defend such "bit fiddling".
Tests are added for all the template engines: Go templates, Ace and Amber.
Fixes #2615
Fixes #1129
Fixes #2590