-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: Add TOML support for language files #3257
Conversation
I will try to figure out tomorrow, why tests are broken. |
Now it works |
It looks good, but I suspect you got it to go green by replacing a YAML test variant with the new TOML -- which doesn't really work; we have to support both, even if TOML is better. This is the error I get when I build my site:
|
It's very strange because it perfectly works with |
Is #3260 somehow related to this error? |
Doubt it. But I will fix that now and then I can check again. |
The problem is what we can't see the errors, which go-i18n returns. |
I reverted that bad merge, and tested this PR with the new master applied, and still get an error. Are you saying we are "swallowing" errors from go-i18n somewhere? |
Yes |
I figured out, where it is: ...
applyDepsIfNeeded(cfg, sites...)
h.Deps = sites[0].Deps
return h, nil
}
func applyDepsIfNeeded(cfg deps.DepsCfg, sites ...*Site) error {
... |
OK, thanks, I will check. |
I've already fixed it. Everything works. I will push it in 5 minutes |
But even if I now get better error message, it still is breaking from this PR:
If I use |
It's because you have blank line at the beginning of your file. If you delete it, everything will operate normally. |
Now everything is fixed. |
Yes, now it works correctly on my site, too. This is just great, you showed some real persistence landing this. This is a way more important feature than most people will appreciate -- until they start to use it in real projects of some size! /cc @spf13 @rdwatters @budparr |
Thank you, @bep 😌 |
Very glad i am embrassing hugo. I have no idea what was going on but i knew i am in good company. |
@BoGeM Thanks a lot for your help, sir! And for the great work on implementing this feature. I appreciate it! 😄 Fixes rdwatters#64 See PR rdwatters#65 and PR gohugoio/hugo#3257
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #2577
Fixes #3200