tpl: Add reflect namespace #4167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Can you please also add the docs for these functions? |
Adds KindIs, KindOf, TypeIs, TypeIsLike, and TypeOf funcs in a reflect namespace. Fixes gohugoio#4081
|
Hold on with the docs until we decide on the API. |
|
As I said in the other PR, we need to be restrictive about adding new template funcs until we fix the docs setup for it. But we cannot build an API where the user has to set up conditionals with this hefty list: * array
* bool
* chan
* complex128
* complex64
* float32
* float64
* func
* int
* int16
* int32
* int64
* int8
* interface
* invalid
* map
* ptr
* slice
* string
* struct
* uint
* uint16
* uint32
* uint64
* uint8
* uintptr
* unsafePointerWe need to discuss a simpler API. But that will have to wait. |
|
@moorereason please create a reflect proposal issue so we can agree on the design. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds KindIs, KindOf, TypeIs, TypeIsLike, and TypeOf funcs in a reflect
namespace.
Fixes #4081