Initial take on adding first class author, media and seo meta support #677
Conversation
derekperkins
changed the title
derekperkins
force-pushed
the
seo-meta
branch
from
91e3f54
to
aac91c7
Compare
|
Discussion on this topic / PR can be found here: http://discuss.gohugo.io/t/hugo-seo-social-partials/353 |
| @@ -0,0 +1,49 @@ | |||
| // Copyright © 2013 Steve Francia <spf@spf13.com>. | |||
| // | |||
| // Licensed under the Simple Public License, Version 2.0 (the "License"); | |||
There was a problem hiding this comment.
Should this code be marked under SPL, or under Apache2, since this is an entirely new contribution?
There was a problem hiding this comment.
Keep it all under the same license until we officially switch. It's cleaner that way.
…tructs Added Page.Author(s) functions Added schema, opengraph, twitter_cards, google_news metadata templates Added "" template
derekperkins
force-pushed
the
seo-meta
branch
from
aac91c7
to
d2f6ecc
Compare
|
@derekperkins Thank you for this work. This looks like a good start and I'm merging it. It's not quite 100% there for me yet though. A lot of times author is provided in the front matter as just a name. I'd like to be able to support either just the author as a string (just the name) or the more complete author here. Additionally I think having an authors.(json, yaml, toml) file next to the config file that had the more structured data and simply referencing that in the content meta data would be ideal. I've been working on Viper to enable additional support for files like this. It's nearly there. Lastly, some of the field names feel a bit verbose. I think the are fine, but I'd like to support aliases.. So if the configuration provided just "bio" it would default to be stored in "longBio" for example. "firstName" -> "GivenName" etc. Does this all make sense? Do you agree? |
|
Merged as 8f6f871 |
|
@spf13 Thanks for merging this, I agree that it's still a WIP. I think multiple config files is a great idea. If we have additional config files like authors.xxxx, then it would be easy in the site initialization to set a flag whether or not author information is available. Then based on that info, it would either just insert the string or return an object. I can switch this up once Viper is ready to handle the extra files. I think adding aliases is a good idea. I grew up in China, where name order is switched, which is why I prefer |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Added AuthorList, Author, AuthorSocial, Image and Video structs
Added Page.Author(s) functions
Added opengraph metadata template
#655 #675