Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish tagged as Github Packages #8700

Closed
wants to merge 1 commit into from
Closed

Publish tagged as Github Packages #8700

wants to merge 1 commit into from

Conversation

gliptak
Copy link

@gliptak gliptak commented Jun 27, 2021

Signed-off-by: Gábor Lipták gliptak@gmail.com

https://github.com/gliptak/hugo/actions/runs/975239969

https://github.com/gliptak/hugo/pkgs/container/hugo

docker run ghcr.io/gliptak/hugo:latest version
hugo v0.85.0-DEV linux/amd64 BuildDate=2021-06-27T01:03:38Z

#5056

Signed-off-by: Gábor Lipták <gliptak@gmail.com>
@gliptak
Copy link
Author

gliptak commented Jun 28, 2021

@bep please approve running workflows

@bep
Copy link
Member

bep commented Jun 28, 2021

@gliptak I'm not approving this until I understand what it does.

@gliptak
Copy link
Author

gliptak commented Jun 28, 2021

@bep details were linked above

as per #5056, while there is a Dockerfile, an image isn't published for hugo

This Github Actions publishes tagged sources as Github Packages

Here is a publishing run on my fork:

https://github.com/gliptak/hugo/actions/runs/975239969

Here is the published artifact in my fork:

https://github.com/gliptak/hugo/pkgs/container/hugo

Here is a sample run for the artifact published on my fork:

docker run ghcr.io/gliptak/hugo:latest version
hugo v0.85.0-DEV linux/amd64 BuildDate=2021-06-27T01:03:38Z

@bep
Copy link
Member

bep commented Jun 28, 2021

OK, thanks, but we're currently not going to do that. I look at the Dockerfile in this repo as a convenience thing. Once we publish it to some official repo we need to do a whole new level of QA, which I'm certainly not prepared to take on at the moment.

@bep bep closed this Jun 28, 2021
@gliptak
Copy link
Author

gliptak commented Jun 28, 2021

@bep considering that testing already happens against ubuntu at https://github.com/gohugoio/hugo/blob/master/.github/workflows/test.yml#L11, the Dockerfile testing might be building it and getting a version number out running it. Let me know if you are interested in a PR updating test.yml with basic Dockerfile testing

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants