Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation link in README.md #368

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Conversation

Jeffwan
Copy link
Contributor

@Jeffwan Jeffwan commented Dec 15, 2019

README.md Link is broken. Should be installing-feast.md

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jeffwan
To complete the pull request process, please assign zhilingc
You can assign the PR to them by writing /assign @zhilingc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot
Copy link
Collaborator

Hi @Jeffwan. Thanks for your PR.

I'm waiting for a gojek member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@woop
Copy link
Member

woop commented Dec 16, 2019

Thanks @Jeffwan!

Would you mind signing the CLA?

As soon as you do I will merge it in.

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Dec 16, 2019

@woop Hi, I already signed CLA. It's the similar one in Kubernetes community, right?
https://cla.developers.google.com/about/google-individual This one?

@woop
Copy link
Member

woop commented Dec 17, 2019

@woop Hi, I already signed CLA. It's the similar one in Kubernetes community, right?
https://cla.developers.google.com/about/google-individual This one?

Yes, thank you!

@woop
Copy link
Member

woop commented Dec 17, 2019

/lgtm

@woop
Copy link
Member

woop commented Dec 17, 2019

/approved

@woop woop merged commit bc4b974 into feast-dev:master Dec 17, 2019
@feast-ci-bot
Copy link
Collaborator

@Jeffwan: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
test-core-and-ingestion 4f01d11 link /test test-core-and-ingestion
test-end-to-end-batch 4f01d11 link /test test-end-to-end-batch

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Jeffwan Jeffwan deleted the fix-doc-link branch December 26, 2019 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants