remove unused variables

httpclient/client.go

@@ -57,10 +57,9 @@ func (c *Client) AddPlugin(p heimdall.Plugin) {
 
 // Get makes a HTTP GET request to provided URL
 func (c *Client) Get(url string, headers http.Header) (*http.Response, error) {
-	var response *http.Response
 	request, err := http.NewRequest(http.MethodGet, url, nil)
 	if err != nil {
-		return response, errors.Wrap(err, "GET - request creation failed")
+		return nil, errors.Wrap(err, "GET - request creation failed")
 	}
 
 	request.Header = headers
@@ -70,10 +69,9 @@ func (c *Client) Get(url string, headers http.Header) (*http.Response, error) {
 
 // Post makes a HTTP POST request to provided URL and requestBody
 func (c *Client) Post(url string, body io.Reader, headers http.Header) (*http.Response, error) {
-	var response *http.Response
 	request, err := http.NewRequest(http.MethodPost, url, body)
 	if err != nil {
-		return response, errors.Wrap(err, "POST - request creation failed")
+		return nil, errors.Wrap(err, "POST - request creation failed")
 	}
 
 	request.Header = headers
@@ -83,10 +81,9 @@ func (c *Client) Post(url string, body io.Reader, headers http.Header) (*http.Re
 
 // Put makes a HTTP PUT request to provided URL and requestBody
 func (c *Client) Put(url string, body io.Reader, headers http.Header) (*http.Response, error) {
-	var response *http.Response
 	request, err := http.NewRequest(http.MethodPut, url, body)
 	if err != nil {
-		return response, errors.Wrap(err, "PUT - request creation failed")
+		return nil, errors.Wrap(err, "PUT - request creation failed")
 	}
 
 	request.Header = headers
@@ -96,10 +93,9 @@ func (c *Client) Put(url string, body io.Reader, headers http.Header) (*http.Res
 
 // Patch makes a HTTP PATCH request to provided URL and requestBody
 func (c *Client) Patch(url string, body io.Reader, headers http.Header) (*http.Response, error) {
-	var response *http.Response
 	request, err := http.NewRequest(http.MethodPatch, url, body)
 	if err != nil {
-		return response, errors.Wrap(err, "PATCH - request creation failed")
+		return nil, errors.Wrap(err, "PATCH - request creation failed")
 	}
 
 	request.Header = headers
@@ -109,10 +105,9 @@ func (c *Client) Patch(url string, body io.Reader, headers http.Header) (*http.R
 
 // Delete makes a HTTP DELETE request with provided URL
 func (c *Client) Delete(url string, headers http.Header) (*http.Response, error) {
-	var response *http.Response
 	request, err := http.NewRequest(http.MethodDelete, url, nil)
 	if err != nil {
-		return response, errors.Wrap(err, "DELETE - request creation failed")
+		return nil, errors.Wrap(err, "DELETE - request creation failed")
 	}
 
 	request.Header = headers
@@ -122,11 +117,9 @@ func (c *Client) Delete(url string, headers http.Header) (*http.Response, error)
 
 // Head makes a HTTP HEAD request with provided URL
 func (c *Client) Head(url string, headers http.Header) (*http.Response, error) {
-	var response *http.Response
-
 	request, err := http.NewRequest(http.MethodHead, url, nil)
 	if err != nil {
-		return response, errors.Wrap(err, "HEAD - request creation failed")
+		return nil, errors.Wrap(err, "HEAD - request creation failed")
 	}
 
 	request.Header = headers