Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom http example #73

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Custom http example #73

merged 2 commits into from
Jan 27, 2020

Conversation

johanavril
Copy link
Contributor

  • add go syntax highlighting
  • fix example got unexpected newline error

@johanavril
fix custom HTTP Client example
f5ac9a7 
The example got an error because it didnt use a proper go syntax.
When an argument is called in a newline, it should be ended with a
comma.
@johanavril
add go markdown syntax highlighting on custom HTTP client example
ad981c1
@johanavril
Copy link
Contributor Author

johanavril commented Jan 18, 2020 •
edited
Loading

failing build is caused by changes in golang/go repo in net/url
fix the unit test to satisfy the changes from go in this PR

@rShetty rShetty merged commit 6d66d7e into gojek:master Jan 27, 2020
@rShetty
Copy link
Contributor

rShetty commented Jan 27, 2020

Thanks @johanavril

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanavril @rShetty