[Akshat] Exit with non-zero status code on proc execution submission …

…and streaming logs errors

cmd/execution/executioner.go

@@ -45,13 +45,15 @@ func NewCmd(printer io.Printer, proctorDClient daemon.Client, osExitFunc func(in
 
 			executedProcName, err := proctorDClient.ExecuteProc(procName, procArgs)
 			if err != nil {
+				osExitFunc(1)
 				printer.Println("Error submitting proc for execution", color.FgRed)
 				return
 			}
 
 			printer.Println("Proc submitted for execution. \nStreaming logs:", color.FgGreen)
 			err = proctorDClient.StreamProcLogs(executedProcName)
 			if err != nil {
+				osExitFunc(1)
 				printer.Println("Error Streaming Logs", color.FgRed)
 				return
 			}

cmd/execution/executioner_test.go

@@ -122,7 +122,11 @@ func (s *ExecutionCmdTestSuite) TestExecutionCmdForProctorDExecutionFailure() {
 
 	s.mockPrinter.On("Println", "Error submitting proc for execution", color.FgRed).Once()
 
-	s.testExecutionCmd.Run(&cobra.Command{}, args)
+	osExitFunc := func(exitCode int) {
+		assert.Equal(s.T(), 1, exitCode)
+	}
+	testExecutionCmdOSExit := NewCmd(s.mockPrinter, s.mockProctorDClient, osExitFunc)
+	testExecutionCmdOSExit.Run(&cobra.Command{}, args)
 
 	s.mockProctorDClient.AssertExpectations(s.T())
 	s.mockPrinter.AssertExpectations(s.T())
@@ -142,7 +146,11 @@ func (s *ExecutionCmdTestSuite) TestExecutionCmdForProctorDLogStreamingFailure()
 	s.mockProctorDClient.On("StreamProcLogs", "executed-proc-name").Return(errors.New("error")).Once()
 	s.mockPrinter.On("Println", "Error Streaming Logs", color.FgRed).Once()
 
-	s.testExecutionCmd.Run(&cobra.Command{}, args)
+	osExitFunc := func(exitCode int) {
+		assert.Equal(s.T(), 1, exitCode)
+	}
+	testExecutionCmdOSExit := NewCmd(s.mockPrinter, s.mockProctorDClient, osExitFunc)
+	testExecutionCmdOSExit.Run(&cobra.Command{}, args)
 
 	s.mockProctorDClient.AssertExpectations(s.T())
 	s.mockPrinter.AssertExpectations(s.T())