Job status api which return the job_execution_status for given job_name #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olttwa
requested changes
Aug 16, 2018
There was a problem hiding this comment.
@prashant3863 everything looks good. We just need 3 more tests (1 in psql client, and 2 in store)
| func (store *store) GetJobStatus(jobName string) (string, error) { | ||
| jobsExecutionAuditLogResult := []postgres.JobsExecutionAuditLog{} | ||
| err := store.postgresClient.Select(&jobsExecutionAuditLogResult, "SELECT job_execution_status from jobs_execution_audit_log where job_name = $1", jobName) | ||
| if err != nil { |
There was a problem hiding this comment.
@prashant3863 Please add test for this condition.
| return "", nil | ||
| } | ||
|
|
||
| return jobsExecutionAuditLogResult[0].JobExecutionStatus, nil |
There was a problem hiding this comment.
@prashant3863 Please add test for this condition.
| JobExecutionStatus: "test-job-execution-status", | ||
| } | ||
|
|
||
| err = postgresClient.NamedExec("INSERT INTO jobs_execution_audit_log (job_name, image_name, job_submitted_for_execution, job_args, job_submission_status, job_execution_status) VALUES (:job_name, :image_name, :job_submitted_for_execution, :job_args, :job_submission_status, :job_execution_status)", jobsExecutionAuditLog) |
There was a problem hiding this comment.
@prashant3863 Can we add a test for select when no rows exist in the db with given job name? That'll satisfy the job not found condition.
olttwa
approved these changes
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.