Fix psuh_to_hub in Trainer when nothing needs pushing (huggingface#23751

)
gojiteji · Jun 5, 2023 · 77e7f8a · 77e7f8a
1 parent a8dc67b
commit 77e7f8a
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/transformers/trainer.py b/src/transformers/trainer.py
@@ -3699,9 +3699,10 @@ def _push_from_checkpoint(self, checkpoint_folder):
                 commit_message = f"Training in progress, step {self.state.global_step}"
             else:
                 commit_message = f"Training in progress, epoch {int(self.state.epoch)}"
-            _, self.push_in_progress = self.repo.push_to_hub(
-                commit_message=commit_message, blocking=False, auto_lfs_prune=True
-            )
+            push_work = self.repo.push_to_hub(commit_message=commit_message, blocking=False, auto_lfs_prune=True)
+            # Return type of `Repository.push_to_hub` is either None or a tuple.
+            if push_work is not None:
+                self.push_in_progress = push_work[1]
         except Exception as e:
             logger.error(f"Error when pushing to hub: {e}")
         finally: