Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing some low-hanging fruit in @gojomo 's epic PR piskvorky#2698.
develop
.max_final_vocab
; will need to look deeper what's going on there, following here..format
etc).segment_wiki.py
I have a better sense of the changes and direction in piskvorky#2698 now. Several comments remain unresolved, but I find that PR impossible to work with on Github. It's so large I can't even track notifications – I have to manually expand all files and look for what changes, new comments… 😱. How do you guys do it?
So I'd propose:
FIXME
to denote sections that must be resolved before a release (like critical bugs, stubs) & grep forFIXME
before a release, to verify none are left. And useTODO
for things that can be released later, incrementally, more "wish list".