access registers with PT_REGS macros & add LINUX_ARCH flags #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfc4n
reviewed
Mar 27, 2022
kern/mysqld56_kern.c
Outdated
| @@ -44,7 +44,7 @@ int mysql56_query(struct pt_regs *ctx) { | |||
| return 0; | |||
| } | |||
|
|
|||
| uint64_t len = (uint64_t) (ctx)->cx; | |||
| uint64_t len = (uint64_t)PT_REGS_PARM1(ctx); | |||
There was a problem hiding this comment.
(ctx)->cx macros is PT_REGS_PARM4 .
There was a problem hiding this comment.
Yes! it's a mistake 👍
correct for PT_REGS_PARM4
|
it's updated now |
|
LGTM, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
access registers with PT_REGS macros and add LINUX_ARCH flags to makefile.