-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openssl: encode the value of fd (ssl->wbio->num) to gen uuid, rather than an unexpected random number #494
Conversation
Please provide a detailed description of the functionality of this PR. Also, read the code carefully to ensure that you are familiar enough with the modified code and understand its purpose. |
hello @wuyexkx |
the format related to uuid is: fmt.Sprintf("%d_%d_%s_%d_%d", se.Pid, se.Tid, CToGoString(se.Comm[:]), se.Fd, se.DataType), example: // https://github.com/openssl/openssl/blob/OpenSSL_1_1_1-stable/ssl/ssl_local.h#L1083 we want to get value of the fd (ssl->wbio->num) from the first arg of SSL_write(SSL *ssl, ...) to encode uuid, |
make the uuid of SSL_write have the same format as the uuid of SSL_read Signed-off-by: wuyexkx <ggstarthh@gmail.com>
OK, I understand what you mean. However, I have a question.
Why is the FD correct in Please also provide a description of how to reproduce it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reproduced it.
LGTM, Thanks.
OK, 3Q very much! |
make the format of uuid consistent with SSL_read, get the fd rather than a random value