Fix keylog mode not working correctly on certain OpenSSL versions #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the problem was the `client_random` member having different offsets within the `ssl3_state_st` structure across various OpenSSL versions Fixes gojue#533
cfc4n
reviewed
Apr 28, 2024
cfc4n
reviewed
Apr 28, 2024
Yes, it's not just a minor difference between 1.1.0 and 1.1.1. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #533
The root cause of the problem was that the offset of the client_random member within the
ssl3_state_ststructure varies across different OpenSSL versions.Although the offsets for the
ssl3_state_st->client_randommember (SSL3_STATE_ST_CLIENT_RANDOM) were already generated for all supported OpenSSL versions, but they were not being utilized correctly.
To solve this issue, the existing
SSL3_STATE_ST_CLIENT_RANDOMoffsets have been integrated into the code, ensuring that ecapture can accurately retrieve theclient_randomvalue from the correct location within thessl3_state_ststructure, regardless of the OpenSSL version being used.