Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix undeclared identifier error when make in debug mode #593

Merged
merged 1 commit into from
Aug 20, 2024
Merged

fix: fix undeclared identifier error when make in debug mode #593

merged 1 commit into from
Aug 20, 2024

Conversation

yuweizzz
Copy link
Contributor

Reproduce: DEBUG=1 make

@cfc4n cfc4n added the 🐞 bug Something isn't working label Aug 20, 2024
cfc4n
cfc4n approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@cfc4n cfc4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I have already added a workflow with DEBUG=1 in another pull request, which will actively detect such bugs in the future.

@cfc4n cfc4n merged commit c9984fc into gojue:master Aug 20, 2024
4 of 6 checks passed
@yuweizzz yuweizzz deleted the fix-v0.8.5 branch September 23, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfc4n cfc4n cfc4n approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuweizzz @cfc4n