Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo: 3中 --> 3种 #641

Merged
merged 6 commits into from
Oct 13, 2024
Merged

typo: 3中 --> 3种 #641

merged 6 commits into from
Oct 13, 2024

Conversation

CC11001100
Copy link
Contributor

@CC11001100 CC11001100 commented Sep 29, 2024

你好,在拜读项目的时候注意到了中文文档里有一个错别字,遂提了个pr,希望能被merge到仓库中 😀

@CC11001100
Copy link
Contributor Author

CI报错了,但我无能为力...囧

@cfc4n cfc4n added the documentation Improvements or additions to documentation label Sep 30, 2024
@cfc4n
Copy link
Member

cfc4n commented Oct 1, 2024

谢谢你的发现。 项目中还有很多文档不完善的地方,能否一并修改了?

比如 README_JA.md 也需要拆分为使用编译两个文档。参考README_CN.md。
比如 https://github.com/orgs/gojue/projects/1/views/1 列出了很多计划,有帮助文档、视频教程、类库支持等任务项。

@CC11001100
Copy link
Contributor Author

谢谢你的发现。 项目中还有很多文档不完善的地方,能否一并修改了?

比如 README_JA.md 也需要拆分为使用编译两个文档。参考README_CN.md。 比如 https://github.com/orgs/gojue/projects/1/views/1 列出了很多计划,有帮助文档、视频教程、类库支持等任务项。

  1. 乐意效劳,不过我对日文不熟悉,我会借助AI大模型来尝试一下尽可能翻译得自然一些
  2. 早就听说过ecapture的大名一直没机会深入研究,等我研究明白了会尝试帮助建设完善ecapture的生态

@cfc4n cfc4n marked this pull request as draft October 4, 2024 03:02
@CC11001100 CC11001100 marked this pull request as ready for review October 12, 2024 12:23
Copy link
Member

@cfc4n cfc4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@cfc4n cfc4n merged commit 95d1dc3 into gojue:master Oct 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants