Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix github action release notes generation #710

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

cfc4n
Copy link
Member

@cfc4n cfc4n commented Dec 29, 2024

User description

Fix the release notes generation in GitHub Actions workflow by:

  1. Using multi-line syntax with EOF delimiter
  2. Properly handle special characters and newlines in release notes output
  3. Update golang.org/x/net to v0.33.0

This fixes the error: "Unable to process file command 'output' successfully"


PR Type

Bug fix, Enhancement


Description

  • Fixed the GitHub Actions workflow for release notes generation by using multi-line syntax with EOF delimiter.
  • Addressed issues with handling special characters and newlines in the release notes output.
  • Updated the golang.org/x/net dependency to version v0.33.0, removing references to the older version.

Changes walkthrough 📝

Relevant files
Bug fix
release.yml
Fix GitHub Actions release notes generation with EOF syntax

.github/workflows/release.yml

  • Updated the GitHub Actions workflow to use multi-line syntax with EOF
    delimiter for release notes generation.
  • Ensured proper handling of special characters and newlines in the
    release notes output.
  • +3/-1     
    Enhancement
    go.sum
    Update `golang.org/x/net` dependency to v0.33.0                   

    go.sum

  • Updated the golang.org/x/net dependency to version v0.33.0.
  • Removed references to the older version of golang.org/x/net.
  • +0/-2     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Fix the release notes generation in GitHub Actions workflow by:
    1. Using multi-line syntax with EOF delimiter
    2. Properly handle special characters and newlines in release notes output
    3. Update golang.org/x/net  to v0.33.0
    
    This fixes the error: "Unable to process file command 'output' successfully"
    @cfc4n cfc4n added the dependencies Pull requests that update a dependency file label Dec 29, 2024
    @cfc4n
    Copy link
    Member Author

    cfc4n commented Dec 29, 2024

    /review

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Possible Syntax Issue

    Ensure that the multi-line syntax with EOF delimiter is correctly handled by the GitHub Actions environment and does not introduce unexpected behavior.

    echo "NOTES<<EOF" >> $GITHUB_OUTPUT
    jq -r .body release_notes.json >> $GITHUB_OUTPUT
    echo "EOF" >> $GITHUB_OUTPUT
    Dependency Update

    Verify that the update to golang.org/x/net to version v0.33.0 does not introduce compatibility issues or unexpected behavior in the application.

    golang.org/x/net v0.33.0 h1:74SYHlV8BIgHIFC/LrYkOGIwL19eTYXQ5wc6TBuO36I=
    golang.org/x/net v0.33.0/go.mod h1:HXLR5J+9DxmrqMwG9qjGCxZ+zKXxBru04zlTvWlWuN4=

    @cfc4n
    Copy link
    Member Author

    cfc4n commented Dec 29, 2024

    /describe

    Copy link

    PR Description updated to latest commit (9e10732)

    @cfc4n cfc4n added this to the stable version v1.0.0 milestone Dec 29, 2024
    @cfc4n cfc4n merged commit b7049df into gojue:master Dec 29, 2024
    7 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    dependencies Pull requests that update a dependency file Review effort [1-5]: 2
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant