This repository has been archived by the owner on Dec 7, 2019. It is now read-only.
WIP json for HTML report. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturdryomov
approved these changes
May 2, 2017
| @SerializedName("ignoredCount") | ||
| val ignoredCount: Int, | ||
|
|
||
| @SerializedName("failedCount") |
There was a problem hiding this comment.
Snake notation? I guess it is more common.
There was a problem hiding this comment.
Ah, yes yes, will do
| @@ -15,6 +15,7 @@ dependencies { | |||
| compile libraries.commanderAndroid | |||
| compile libraries.apacheCommonsIo | |||
| compile libraries.apacheCommonsLang | |||
| compile libraries.gson | |||
There was a problem hiding this comment.
KotlinJsonAdapter not released yet
| } | ||
| .map { adbDeviceTestRuns -> | ||
| when (args.shard) { | ||
| // In "shard=true" mode test runs from all devices combined into one suite of tests. |
There was a problem hiding this comment.
Autoformat :(
yunikkk
reviewed
May 2, 2017
| @@ -74,7 +74,7 @@ private fun parseInstrumentationEntry(str: String): InstrumentationEntry = | |||
| } | |||
| .let { statusCode -> | |||
| when (statusCode) { | |||
| null -> throw IllegalStateException("Unknown test result status code [$statusCode], please report that to Composer maintainers $str") | |||
| null -> throw IllegalStateException("Unknown test status status code [$statusCode], please report that to Composer maintainers $str") | |||
There was a problem hiding this comment.
"status status code" or just "status code"?
There was a problem hiding this comment.
my bad, thanks
dmitry-novikov
approved these changes
May 2, 2017
yunikkk
approved these changes
May 2, 2017
| status = when (status) { | ||
| AdbDeviceTest.Status.Passed -> HtmlTest.Status.Passed | ||
| AdbDeviceTest.Status.Ignored -> HtmlTest.Status.Ignored | ||
| is AdbDeviceTest.Status.Failed -> HtmlTest.Status.Failed |
There was a problem hiding this comment.
yes, it's a class, not an object
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #11.
@ming13, @dmitry-novikov PTAL — it's core of implementation, no tests yet since, as I've said I had to "duplicate" some classes like Test/Suite/Device across different layers, I now have an idea to divide Composer into separate (in code) pieces:
Testentity.TestandTestRunentities that have not only basic test info but also screenshots, files and some meta info.Then JUnit4 and HTML reports can be completely unaware of underlying details of execution.