Add reactor extensions. #9
Conversation
|
|
||
| dependencies { | ||
| testCompile libraries.spek | ||
| testCompile libraries.spekJunitPlatformEngine |
There was a problem hiding this comment.
Please add testCompile libraries.junitPlatformLauncher as you did in the previous PR #8 :)
| * </dl> | ||
| * | ||
| * @return a Flux that emits `Some.value` of those items emitted by the source Flux that are `Some`. | ||
| * @see <a href="http://reactivex.io/documentation/operators/filter.html">ReactiveX operators documentation: Filter</a> |
There was a problem hiding this comment.
I guess we should use Reactor's pictures here https://raw.githubusercontent.com/reactor/reactor-core/v3.1.0.M2/src/docs/marble/filter.png
| * </dl> | ||
| * | ||
| * @return a Flux that emits `Unit` for each item emitted by the source Flux that is `None`. | ||
| * @see <a href="http://reactivex.io/documentation/operators/filter.html">ReactiveX operators documentation: Filter</a> |
There was a problem hiding this comment.
| * <p> | ||
| * <img width="640" height="310" src="https://raw.github.com/wiki/ReactiveX/RxJava/images/rx-operators/filter.png" alt=""> | ||
| * <dl> | ||
| * <dt><b>Scheduler:</b></dt> |
There was a problem hiding this comment.
Let's remove note about scheduling, it's standard for RxJava, but not part of javadoc for operators in Reactor
|
|
||
| val stepVerifier by memoized { | ||
| StepVerifier.create( | ||
| stream.filterSome() |
|
|
||
| val subscriber by memoized { | ||
| StepVerifier.create( | ||
| stream.filterNone() |
|
Thanks for the review, made changes accordingly. |
|
Please give us a day or couple to discuss whether we'd like to make this part of Koptional repo or not since we're active RxJava users but not users of Project Reactor, I think decision will be positive but let's see :) |
|
So we've discussed this and decided to merge, thanks for addition, will do release today! |
|
@utwyko FYI we released 1.1.0 with your extensions, however Bintray did not link it to jcenter repo for some reason (as usual uh), I've contacted them and hope to fix this soon (last time similar issue took about 4 days to resolve). For now your extension is available on https://dl.bintray.com/gojuno/maven/com/gojuno/koptional/, once issue will be resolved it should also become available on https://jcenter.bintray.com/com/gojuno/koptional/ |
|
@artem-zinnatullin Great, thanks for the info. |
|
@utwyko Reactor extensions are now available on Jcenter |
Thanks for creating this library, it solves a problem I have constantly while working with Reactive Streams.
I've added a module with extensions for the implementation I work with the most often: Project Reactor.