Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default merge strategy #1339

Closed
joelim-work opened this issue Jul 11, 2023 · 2 comments
Closed

Default merge strategy #1339

joelim-work opened this issue Jul 11, 2023 · 2 comments

Comments

@joelim-work
Copy link
Collaborator

Hi @gokcehan,

I have just merged #1335 and #1336, but I have found that they create merge commits on the master branch, which makes the history look a bit more ugly. Judging from the commit history, I think what you prefer is squash merging?

In any case I think it would be better if you go into the repo settings and disable certain types of merging - as a collaborator I don't have access to this. I'm not sure if you also want to manually force push and clean up the history from these two commits, but I will leave this decision up to you.

My apologies for causing you any inconvenience.

@gokcehan
Copy link
Owner

@joelim-work It's no problem at all. I don't think we need force clean-up. I have now changed the repo settings to only allow squash merging from now on. Thanks for the warning.

@joelim-work
Copy link
Collaborator Author

Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants