Prevent image preview flicker for load
command
#1335
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation from the discussion in #1281. In my opinion the
load
command should not refresh the image preview, but only check whether files/directories have been modified. In the case that there are modifications, the image preview will be refreshed through calling thenav.checkDir
andnav.checkReg
functions. This is the same as how theperiod
timer behaves, and is also implied by the documentation:lf/doc.go
Lines 823 to 829 in 2f3c170
I understand the
load
command is used internally after updates such asrename
,delete
andpaste
, but in each case there will be modifications to the filesystem so the image preview will be refreshed anyway as described above. For me this works fine, but I suppose it would be nice if others test it as well, preferably with image previews.